[chore] raster tile layer tests - #3152
Merged
Merged
Conversation
igorDykhta
commented
Jul 8, 2025
igorDykhta
commented
Collaborator
- missing raster tile layer tests
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive browser tests for the RasterTileLayer to ensure its constructor, data formatting, rendering, configuration updates, and edge-case behaviors are validated, and it hooks the new spec into the test suite.
- Introduces
raster-tile-layer-specs.jswith tests covering constructor defaults,formatLayerData,renderLayer, config/meta updates, default props, visual channels, pixel tracking, rendering toggles, and error/edge cases. - Updates
index.jsto import the new raster tile layer tests.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/browser/layer-tests/raster-tile-layer-specs.js | Adds end-to-end tests for RasterTileLayer |
| test/browser/layer-tests/index.js | Imports the new raster tile layer spec file |
Comments suppressed due to low confidence (1)
test/browser/layer-tests/raster-tile-layer-specs.js:158
- [nitpick] Test only verifies that
stacLayersis an array and its length is non-negative; consider adding assertions to verify that it returns the expected layer count and properties (e.g., instance ofTileLayer, correcttileSourceor dataset).
const stacLayers = layer.renderLayer(stacRenderOpts);
ilyabo
self-requested a review
July 10, 2025 13:27
ilyabo
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.